Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Nov 6, 2025

ARCH-1865

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Breaking Changes
    • Removed the livechat:removeTag public API method in a major version release. Applications using this method require migration to alternative endpoints for tag removal operations.

@juliajforesti juliajforesti added this to the 8.0.0 milestone Nov 6, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 6, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

🦋 Changeset detected

Latest commit: 0bf8a00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR removes the deprecated livechat:removeTag Meteor method from the public API with a major version bump. This includes deleting the method registration, type definitions, index import, and migrating test code from the Meteor method to the new REST endpoint.

Changes

Cohort / File(s) Change Summary
Version & Deprecation Notice
.changeset/short-pots-lay.md
Added changeset documenting major version bump for @rocket.chat/meteor and removal of deprecated livechat:removeTag public API method.
Enterprise Livechat Method Removal
apps/meteor/ee/app/livechat-enterprise/server/methods/removeTag.ts
Deleted entire file containing the Meteor method registration for livechat:removeTag, including permission checks, validation, and type definitions for the ServerMethods interface.
Enterprise Livechat Index
apps/meteor/ee/app/livechat-enterprise/server/index.ts
Removed import statement for ./methods/removeTag to eliminate method registration side effects.
Test Data Migration
apps/meteor/tests/data/livechat/tags.ts
Updated removeTag() test helper to use REST endpoint api('livechat/tags.delete') instead of Meteor method call, adjusting request payload and response parsing accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Straightforward removal of deprecated method across localized files
  • Migration in test file follows expected pattern (Meteor method → REST endpoint)
  • Verify no other references to livechat:removeTag exist in codebase
  • Confirm alignment with accompanying PR that introduces the REST replacement endpoint

Possibly related PRs

Suggested reviewers

  • aleksandernsilva

Poem

🐰 A tag removal quest, deprecated and worn,
The Meteor method bids us farewell at dawn,
REST endpoints rise to take its place,
Cleaning code with grace and haste! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-removeTag

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 589f2a1 and 0bf8a00.

📒 Files selected for processing (4)
  • .changeset/short-pots-lay.md (1 hunks)
  • apps/meteor/ee/app/livechat-enterprise/server/index.ts (0 hunks)
  • apps/meteor/ee/app/livechat-enterprise/server/methods/removeTag.ts (0 hunks)
  • apps/meteor/tests/data/livechat/tags.ts (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.92%. Comparing base (589f2a1) to head (0bf8a00).
⚠️ Report is 3 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #37406      +/-   ##
=================================================
- Coverage          70.93%   70.92%   -0.02%     
=================================================
  Files               3035     3035              
  Lines             104621   104621              
  Branches           18424    18427       +3     
=================================================
- Hits               74217    74206      -11     
- Misses             28460    28468       +8     
- Partials            1944     1947       +3     
Flag Coverage Δ
unit 72.28% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti force-pushed the chore/remove-removeTag branch from d70e928 to f962d67 Compare November 6, 2025 18:21
@ggazzo ggazzo marked this pull request as ready for review November 7, 2025 14:47
@ggazzo ggazzo requested a review from a team as a code owner November 7, 2025 14:47
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Nov 7, 2025
@ggazzo ggazzo merged commit 4fbf612 into release-8.0.0 Nov 7, 2025
34 of 35 checks passed
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 7, 2025
@ggazzo ggazzo deleted the chore/remove-removeTag branch November 7, 2025 14:48
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants